flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2418: [FLINK-4245] JMXReporter exposes all defined varia...
Date Wed, 26 Oct 2016 15:19:32 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2418#discussion_r85145059
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
    @@ -112,6 +116,43 @@ public AbstractMetricGroup(MetricRegistry registry, String[] scope,
A parent) {
     	}
     
     	/**
    +	 * Returns the logical scope of this group, for example
    +	 * {@code "taskmanager.job.task"}
    +	 *
    +	 * @param filter character filter which is applied to the scope components
    +	 * @return logical scope
    +	 */
    +	public String getLogicalScope(CharacterFilter filter) {
    +		return getLogicalScope(filter, registry.getDelimiter());
    +	}
    +
    +	/**
    +	 * Returns the logical scope of this group, for example
    +	 * {@code "taskmanager.job.task"}
    +	 *
    +	 * @param filter character filter which is applied to the scope components
    +	 * @return logical scope
    +	 */
    +	public String getLogicalScope(CharacterFilter filter, Character delimiter) {
    --- End diff --
    
    Can this be a primitive `char`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message