flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2655: [FLINK-4851] [rm] Introduce FatalErrorHandler and ...
Date Sat, 22 Oct 2016 09:07:12 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2655#discussion_r84573260
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/ResourceManagerJobMasterTest.java
---
    @@ -145,6 +171,10 @@ public void testRegisterJobMasterWithFailureLeaderListener() throws
Exception {
     		Future<RegistrationResponse> declineFuture = resourceManager.registerJobMaster(rmLeaderSessionId,
jmLeaderSessionId, jobMasterAddress, unknownJobIDToHAServices);
     		RegistrationResponse response = declineFuture.get(5, TimeUnit.SECONDS);
     		assertTrue(response instanceof RegistrationResponse.Decline);
    +
    +		if (testingFatalErrorHandler.hasExceptionOccurred()) {
    +			testingFatalErrorHandler.rethrowError();
    +		}
    --- End diff --
    
    Yes I think this makes sense for all of the distributed components RM, JM and TM. It would
 be good to instantiate default components which you can replace with a special version of
a component in case you need it for a test. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message