flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink issue #2628: [FLINK-3722] [runtime] Don't / and % when sorting
Date Thu, 20 Oct 2016 13:57:41 GMT
Github user greghogan commented on the issue:

    Thanks @ggevay for reviewing. I added a commit with additional comments.
    I transcribed `Quicksort` so as to remove considerations of Java performance and inlining.
It was not clear to me that if we encapsulated the index, page number, and page offset into
an object that Java would inline the various increment and decrement functions. Also, I don't
think this looks too bad. I'm happy to reformat if that is preferred.
    I think this is the best time to investigate alternative methods. I'm not seeing how one
would sort on top of `InMemorySorter` without deserializing records.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message