flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...
Date Wed, 19 Oct 2016 10:58:08 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84027778
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
    @@ -725,7 +755,21 @@ else if (response != RETURN_OKAY) {
     			Object msg = JobManagerMessages.getRequestBlobManagerPort();
     			Future<Object> futureBlobPort = jobManager.ask(msg, askTimeout);
     
    +			Object secureCookieMsg = JobManagerMessages.getRequestBlobManagerSecureCookie();
    +			Future<Object> futureSecureCookie = jobManager.ask(secureCookieMsg, askTimeout);
    +
     			try {
    +				String secureCookie = null;
    +
    +				Object cookie = Await.result(futureSecureCookie, askTimeout);
    +				if(cookie instanceof String) {
    +					secureCookie = (String) cookie;
    +				}
    --- End diff --
    
    We are transferring the cookie here from the JobManager? That should never be the case.
The client has to provide the cookie, otherwise a client must not be able to communicate with
the JobManager.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message