flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2618: Refactoring the Continuous File Monitoring Functio...
Date Wed, 12 Oct 2016 14:54:09 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2618#discussion_r83005668
  
    --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingTests.java
---
    @@ -111,8 +114,8 @@ public void testFileReadingOperatorWithIngestionTime() throws Exception
{
     		Set<org.apache.hadoop.fs.Path> filesCreated = new HashSet<>();
     		Map<Integer, String> expectedFileContents = new HashMap<>();
     
    -		for(int i = 0; i < NO_OF_FILES; i++) {
    -			Tuple2<org.apache.hadoop.fs.Path, String> file = fillWithData(hdfsURI, "file",
i, "This is test line.");
    +		for (int i = 0; i < NO_OF_FILES; i++) {
    +			Tuple2<org.apache.hadoop.fs.Path, String> file = createFileAndFillWithData(hdfsURI,
"file", i, "This is test line.");
    --- End diff --
    
    This can probably be moved into a `@Before` method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message