flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2562: [FLINK-4691] [table] Add group-windows for streami...
Date Wed, 05 Oct 2016 14:53:18 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2562#discussion_r81957188
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
    @@ -497,3 +501,95 @@ case class LogicalRelNode(
     
       override def validate(tableEnv: TableEnvironment): LogicalNode = this
     }
    +
    +case class WindowAggregate(
    +    groupingExpressions: Seq[Expression],
    +    window: LogicalWindow,
    +    aggregateExpressions: Seq[NamedExpression],
    +    child: LogicalNode)
    +  extends UnaryNode {
    +
    +  override def output: Seq[Attribute] = {
    +    (groupingExpressions ++ aggregateExpressions) map {
    +      case ne: NamedExpression => ne.toAttribute
    +      case e => Alias(e, e.toString).toAttribute
    +    }
    +  }
    +
    +  override def resolveReference(
    --- End diff --
    
    please add inline comments to make the code easier to follow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message