Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 28 Sep 2016 12:51:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13008031.1475003287000.686750.1475067080975@Atlassian.JIRA>
In-Reply-To: <JIRA.13008031.1475003287000@Atlassian.JIRA>
References: <JIRA.13008031.1475003287000@Atlassian.JIRA> <JIRA.13008031.1475003287537@arcas>
Subject: [jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets
 asynchronously
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 28 Sep 2016 12:51:23 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529502#comment-15529502 ] 

ASF GitHub Bot commented on FLINK-4702:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2559#discussion_r80907326
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java ---
    @@ -285,7 +293,14 @@ public void commitSpecificOffsetsToKafka(Map<KafkaTopicPartition, Long> offsets)
     
     		if (this.consumer != null) {
     			synchronized (consumerLock) {
    -				this.consumer.commitSync(offsetsToCommit);
    +				if (!commitInProgress) {
    +					commitInProgress = true;
    +					this.consumer.commitAsync(offsetsToCommit, offsetCommitCallback);
    +				}
    +				else {
    +					LOG.warn("Committing previous checkpoint's offsets to Kafka not completed. " +
    --- End diff --
    
    If the user sets a relatively short checkpoint interval, will this be flooding log?


> Kafka consumer must commit offsets asynchronously
> -------------------------------------------------
>
>                 Key: FLINK-4702
>                 URL: https://issues.apache.org/jira/browse/FLINK-4702
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.1.2
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.2.0, 1.1.3
>
>
> The offset commit calls to Kafka may occasionally take very long.
> In that case, the {{notifyCheckpointComplete()}} method blocks for long and the KafkaConsumer cannot make progress and cannot perform checkpoints.
> Kafka 0.9+ have methods to commit asynchronously.
> We should use those and make sure no more than one commit is concurrently in progress, to that commit requests do not pile up.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)