Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 94B8F200B95 for ; Tue, 27 Sep 2016 19:03:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9365C160AEC; Tue, 27 Sep 2016 17:03:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E8669160AB9 for ; Tue, 27 Sep 2016 19:03:21 +0200 (CEST) Received: (qmail 3182 invoked by uid 500); 27 Sep 2016 17:03:21 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 3145 invoked by uid 99); 27 Sep 2016 17:03:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Sep 2016 17:03:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E42C12C2A66 for ; Tue, 27 Sep 2016 17:03:20 +0000 (UTC) Date: Tue, 27 Sep 2016 17:03:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4657) Implement HighAvailabilityServices based on zookeeper MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 27 Sep 2016 17:03:22 -0000 [ https://issues.apache.org/jira/browse/FLINK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526750#comment-15526750 ] ASF GitHub Bot commented on FLINK-4657: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2550#discussion_r80734121 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -467,6 +487,128 @@ public void registerAtResourceManager(final String address) { //TODO:: register at the RM } + @RpcMethod + public NextInputSplit requestNextInputSplit(final JobVertexID vertexID, final ExecutionAttemptID executionAttempt) { + final byte[] serializedInputSplit; + + final Execution execution = executionGraph.getRegisteredExecutions().get(executionAttempt); + if (execution == null) { + log.error("Can not find Execution for attempt {}.", executionAttempt); + return null; --- End diff -- Let's let this throw an exception - after all, the caller receiver should react to the fact that the JobManager is not aware of its execution any more. > Implement HighAvailabilityServices based on zookeeper > ----------------------------------------------------- > > Key: FLINK-4657 > URL: https://issues.apache.org/jira/browse/FLINK-4657 > Project: Flink > Issue Type: New Feature > Components: Cluster Management > Reporter: Kurt Young > Assignee: Kurt Young > > For flip-6, we will have ResourceManager and every JobManager as potential leader contender and retriever. We should separate them by using different zookeeper path. > For example, the path could be /leader/resource-manaeger for RM. And for each JM, the path could be /leader/job-managers/JobID -- This message was sent by Atlassian JIRA (v6.3.4#6332)