Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 15 Sep 2016 16:50:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13004592.1473773874000.581830.1473958220704@Atlassian.JIRA>
In-Reply-To: <JIRA.13004592.1473773874000@Atlassian.JIRA>
References: <JIRA.13004592.1473773874000@Atlassian.JIRA> <JIRA.13004592.1473773874499@arcas>
Subject: [jira] [Commented] (FLINK-4615) Reusing the memory allocated for
 the drivers and iterators
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 15 Sep 2016 16:50:23 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493897#comment-15493897 ] 

ASF GitHub Bot commented on FLINK-4615:
---------------------------------------

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2496#discussion_r79010283
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
    @@ -87,4 +87,6 @@
     	 * @throws Exception Exceptions may be forwarded.
     	 */
     	void cancel() throws Exception;
    +
    +	void resetForIterativeTasks() throws Exception;
    --- End diff --
    
    > You mean all drivers will now become a type of ResettableDriver?
    
    Yes, this was the idea in my comment [1] on the Jira. I'm sorry if I wasn't clear enough there.
    The advantage of this is that you wouldn't need to add more logic in `BatchTask`, `AbstractIterativeTask` and its descendants, because these already handle the situation when the driver is an instance of `ResettableDriver`. (See e.g. the beginning of `reinstantiateDriver`.)
    
    [1] https://issues.apache.org/jira/browse/FLINK-3322?focusedCommentId=15474531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15474531


> Reusing the memory allocated for the drivers and iterators
> ----------------------------------------------------------
>
>                 Key: FLINK-4615
>                 URL: https://issues.apache.org/jira/browse/FLINK-4615
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Local Runtime
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 1.0.0
>
>
> Raising as a subtask so that individually can be committed and for better closer reviews.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)