Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C470E200B7D for ; Sat, 10 Sep 2016 23:09:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C303A160AD2; Sat, 10 Sep 2016 21:09:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3CCEF160AA5 for ; Sat, 10 Sep 2016 23:09:23 +0200 (CEST) Received: (qmail 915 invoked by uid 500); 10 Sep 2016 21:09:22 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 896 invoked by uid 99); 10 Sep 2016 21:09:22 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Sep 2016 21:09:22 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3A6C62C1B7F for ; Sat, 10 Sep 2016 21:09:22 +0000 (UTC) Date: Sat, 10 Sep 2016 21:09:22 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 10 Sep 2016 21:09:24 -0000 [ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480465#comment-15480465 ] ASF GitHub Bot commented on FLINK-4610: --------------------------------------- Github user apivovarov commented on the issue: https://github.com/apache/flink/pull/2491 @twalthr Can you look at this PR? > Replace keySet/getValue with entrySet in UdfAnalyzerUtils > --------------------------------------------------------- > > Key: FLINK-4610 > URL: https://issues.apache.org/jira/browse/FLINK-4610 > Project: Flink > Issue Type: Improvement > Components: Java API > Affects Versions: 1.1.2 > Reporter: Alexander Pivovarov > Priority: Minor > > Map.keySet + getValue combination is not very efficient > It can be replaced with Map.entrySet to avoid values lookup > Also MapEntry allows to modify MapEntry value while iterating thought the map using entrySet.iterator -- This message was sent by Atlassian JIRA (v6.3.4#6332)