Return-Path: <issues-return-71891-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 55577200B8E
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 26 Sep 2016 15:28:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 5251C160AE3; Mon, 26 Sep 2016 13:28:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 99482160AB8
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 26 Sep 2016 15:28:21 +0200 (CEST)
Received: (qmail 81765 invoked by uid 500); 26 Sep 2016 13:28:20 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 81730 invoked by uid 99); 26 Sep 2016 13:28:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Sep 2016 13:28:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 835E32C0032
	for <issues@flink.apache.org>; Mon, 26 Sep 2016 13:28:20 +0000 (UTC)
Date: Mon, 26 Sep 2016 13:28:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13004034.1473477327000.663111.1474896500533@Atlassian.JIRA>
In-Reply-To: <JIRA.13004034.1473477327000@Atlassian.JIRA>
References: <JIRA.13004034.1473477327000@Atlassian.JIRA> <JIRA.13004034.1473477327214@arcas>
Subject: [jira] [Commented] (FLINK-4606) Integrate the new ResourceManager
 with the existing FlinkResourceManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Mon, 26 Sep 2016 13:28:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523054#comment-15523054 ] 

ASF GitHub Bot commented on FLINK-4606:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2540#discussion_r80473835
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ---
    @@ -66,15 +67,16 @@
      *     <li>{@link #requestSlot(SlotRequest)} requests a slot from the resource manager</li>
      * </ul>
      */
    -public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> implements LeaderContender {
    +public abstract class ResourceManager<ResourceManagerGateway, WorkerType extends TaskExecutorRegistration> extends RpcEndpoint implements LeaderContender {
    --- End diff --
    
    I believe this should be 
    
    ```java
     ResourceManager<WorkerType extends TaskExecutorRegistration>
    		extends RpcEndpoint<ResourceManagerGateway>
    ```


> Integrate the new ResourceManager with the existing FlinkResourceManager
> ------------------------------------------------------------------------
>
>                 Key: FLINK-4606
>                 URL: https://issues.apache.org/jira/browse/FLINK-4606
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: zhangjing
>            Assignee: zhangjing
>
> Integrate the new ResourceManager with the existing FlinkResourceManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)