Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Wed, 21 Sep 2016 07:28:20 +0000 (UTC)
From: "Nagarjun Guraja (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13003419.1473298510000.624130.1474442900549@Atlassian.JIRA>
In-Reply-To: <JIRA.13003419.1473298510000@Atlassian.JIRA>
References: <JIRA.13003419.1473298510000@Atlassian.JIRA> <JIRA.13003419.1473298510025@arcas>
Subject: [jira] [Updated] (FLINK-4596) RESTART_STRATEGY is not really
 pluggable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 21 Sep 2016 07:28:22 -0000


     [ https://issues.apache.org/jira/browse/FLINK-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nagarjun Guraja updated FLINK-4596:
-----------------------------------
    Description: 
Standalone cluster config accepts an implementation(class) as part of the yaml config file but that does not work either as cluster level restart strategy or streaming job level restart strategy

CLUSTER LEVEL CAUSE: createRestartStrategyFactory converts configured value of strategyname to lowercase and searches for class name using lowercased string.
JOB LEVEL CAUSE: Checkpointed streams have specific code to add fixeddelayrestartconfiguration if no RestartConfiguration is specified in  the job env. Also, jobs cannot provide their own custom restart strategy implementation and are constrained to pick up one of the three restart strategies provided by flink. 

FIX: Do not lower case the strategy config value, support a new restartconfiguration to fallback to cluster level restart strategy and support jobs to provide custom implementation of the strategy class itself.

  was:
CAUSE: createRestartStrategyFactory converts configured value of strategyname to lowercase and searches for class name using lowercased string.  

FIX: Do not lower case the strategy config value or just lowercase for the switch case alone


> RESTART_STRATEGY is not really pluggable
> ----------------------------------------
>
>                 Key: FLINK-4596
>                 URL: https://issues.apache.org/jira/browse/FLINK-4596
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Nagarjun Guraja
>
> Standalone cluster config accepts an implementation(class) as part of the yaml config file but that does not work either as cluster level restart strategy or streaming job level restart strategy
> CLUSTER LEVEL CAUSE: createRestartStrategyFactory converts configured value of strategyname to lowercase and searches for class name using lowercased string.
> JOB LEVEL CAUSE: Checkpointed streams have specific code to add fixeddelayrestartconfiguration if no RestartConfiguration is specified in  the job env. Also, jobs cannot provide their own custom restart strategy implementation and are constrained to pick up one of the three restart strategies provided by flink. 
> FIX: Do not lower case the strategy config value, support a new restartconfiguration to fallback to cluster level restart strategy and support jobs to provide custom implementation of the strategy class itself.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)