Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Mon, 26 Sep 2016 09:30:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.13001949.1472721617000.661574.1474882220521@Atlassian.JIRA>
In-Reply-To: <JIRA.13001949.1472721617000@Atlassian.JIRA>
References: <JIRA.13001949.1472721617000@Atlassian.JIRA> <JIRA.13001949.1472721617575@arcas>
Subject: [jira] [Commented] (FLINK-4552) Refactor WindowOperator/Trigger
 Tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 26 Sep 2016 09:30:27 -0000


    [ https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522565#comment-15522565 ] 

ASF GitHub Bot commented on FLINK-4552:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/2547
  
    There is a failing test:`TimestampsAndPeriodicWatermarksOperatorTest.testTimestampsAndPeriodicWatermarksOperator(TimestampsAndPeriodicWatermarksOperatorTest.java:74)`


> Refactor WindowOperator/Trigger Tests
> -------------------------------------
>
>                 Key: FLINK-4552
>                 URL: https://issues.apache.org/jira/browse/FLINK-4552
>             Project: Flink
>          Issue Type: Improvement
>          Components: Windowing Operators
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> Right now, tests for {{WindowOperator}}, {{WindowAssigner}}, {{Trigger}} and {{WindowFunction}} are all conflated in {{WindowOperatorTest}}. All of these test that a certain combination of a {{Trigger}}, {{WindowAssigner}} and {{WindowFunction}} produce the expected output.
> We should modularize these tests and spread them out across multiple files, possibly one per trigger, for the triggers. Also, we should extend/change the tests in some key ways:
>  - {{WindowOperatorTest}} test should just verify that the interaction between {{WindowOperator}} and the various other parts works as expected, that the correct methods on {{Trigger}} and {{WindowFunction}} are called at the expected time and that snapshotting, timers, cleanup etc. work correctly. These tests should also verify that the different state types and {{WindowFunctions}} work correctly.
>  - {{Trigger}} tests should present elements to triggers and verify that they fire at the correct times. The actual output of the {{WindowFunction}} is not important for these tests. We should also test that triggers correctly clean up state and timers.
>  - {{WindowAssigner}} tests should test each window assigner and also verify that, for example, the offset parameter of time-based windows works correctly.
> There is already {{WindowingTestHarness}} but it is not used by tests, I think we can expand on that and provide more thorough test coverage while also making the tests more maintainable ({{WindowOperatorTest.java}} is nearing 3000 lines of code).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)