Return-Path: <issues-return-70028-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 54307200B8D
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  8 Sep 2016 13:21:22 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 530C1160AA5; Thu,  8 Sep 2016 11:21:22 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id A1A27160ABD
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  8 Sep 2016 13:21:21 +0200 (CEST)
Received: (qmail 60679 invoked by uid 500); 8 Sep 2016 11:21:20 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 60647 invoked by uid 99); 8 Sep 2016 11:21:20 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2016 11:21:20 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id B5D362C1B86
	for <issues@flink.apache.org>; Thu,  8 Sep 2016 11:21:20 +0000 (UTC)
Date: Thu, 8 Sep 2016 11:21:20 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12948733.1457605365000.518983.1473333680742@Atlassian.JIRA>
In-Reply-To: <JIRA.12948733.1457605365000@Atlassian.JIRA>
References: <JIRA.12948733.1457605365000@Atlassian.JIRA> <JIRA.12948733.1457605365868@arcas>
Subject: [jira] [Commented] (FLINK-3599) GSoC: Code Generation in
 Serializers
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Thu, 08 Sep 2016 11:21:22 -0000


    [ https://issues.apache.org/jira/browse/FLINK-3599?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1547=
3590#comment-15473590 ]=20

ASF GitHub Bot commented on FLINK-3599:
---------------------------------------

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2211#discussion_r77987928
 =20
    --- Diff: flink-core/src/main/java/org/apache/flink/api/java/typeutils/=
PojoTypeInfo.java ---
    @@ -70,10 +77,41 @@
     =09private static final Pattern PATTERN_NESTED_FIELDS =3D Pattern.comp=
ile(REGEX_NESTED_FIELDS);
     =09private static final Pattern PATTERN_NESTED_FIELDS_WILDCARD =3D Pat=
tern.compile(REGEX_NESTED_FIELDS_WILDCARD);
    =20
    +=09private static final Map<Class<?>, Class<? extends TypeSerializer>>=
 customSerializers =3D new HashMap<>();
    +=09private static final Map<Tuple2<ArrayList<Integer>, Class>, Class<?=
 extends TypeComparator>> customComparators =3D
    +=09=09new HashMap<>();
    +
     =09private final PojoField[] fields;
     =09
     =09private final int totalFields;
    =20
    +=09/**
    +=09 * Register a custom serializer for a type. The precedence of the s=
erializers
    +=09 * is the following (highest to lowest): Kryo, Avro, Custom, Genera=
ted, Flink.
    +=09 * The chosen serializer will be the first one from the list that i=
s turned on.
    --- End diff --
   =20
    I'm also not sure about putting "Custom" after "Kryo" and "Avro". The r=
eason for having a custom serializer is kind of that I want to bypass all t=
his mess. Or to reason from an other angle, why would I have a custom seria=
lizer, if it doesn't work, and Kryo has to take over?


> GSoC: Code Generation in Serializers
> ------------------------------------
>
>                 Key: FLINK-3599
>                 URL: https://issues.apache.org/jira/browse/FLINK-3599
>             Project: Flink
>          Issue Type: Improvement
>          Components: Type Serialization System
>            Reporter: M=C3=A1rton Balassi
>            Assignee: Gabor Horvath
>              Labels: gsoc2016, mentor
>
> The current implementation of the serializers can be a
> performance bottleneck in some scenarios. These performance problems were
> also reported on the mailing list recently [1].
> E.g. the PojoSerializer uses reflection for accessing the fields, which i=
s slow [2].
> For the complete proposal see [3].
> [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Tuple-=
performance-and-the-curious-JIT-compiler-td10666.html
> [2] https://github.com/apache/flink/blob/master/flink-core/src/main/java/=
org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java#L369
> [3] https://docs.google.com/document/d/1VC8lCeErx9kI5lCMPiUn625PO0rxR-iKl=
Vqtt3hkVnk



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)