Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3DDB9200B8F for ; Fri, 30 Sep 2016 11:07:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3C9BA160AD9; Fri, 30 Sep 2016 09:07:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 821B2160AC4 for ; Fri, 30 Sep 2016 11:07:03 +0200 (CEST) Received: (qmail 16707 invoked by uid 500); 30 Sep 2016 09:07:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 16698 invoked by uid 99); 30 Sep 2016 09:07:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2016 09:07:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5BCCCC3351 for ; Fri, 30 Sep 2016 09:07:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -7.019 X-Spam-Level: X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id mhvgq9I3c3s5 for ; Fri, 30 Sep 2016 09:07:00 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 61B6D5FBB4 for ; Fri, 30 Sep 2016 09:06:59 +0000 (UTC) Received: (qmail 16652 invoked by uid 99); 30 Sep 2016 09:06:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Sep 2016 09:06:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 72A69E04BE; Fri, 30 Sep 2016 09:06:58 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #2574: [FLINK-4702] [kafka connector] Commit offsets to Kafka as... Content-Type: text/plain Message-Id: <20160930090658.72A69E04BE@git1-us-west.apache.org> Date: Fri, 30 Sep 2016 09:06:58 +0000 (UTC) archived-at: Fri, 30 Sep 2016 09:07:04 -0000 Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2574 Thanks for the review. I think some points you mentioned are already addressed, actually. Will add the following: - `commitSpecificOffsets()` can determine precisely when a commit request is subsumed by a new one - Extend test to catch errors from committer thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---