Return-Path: <issues-return-72491-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 07911200B91
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 29 Sep 2016 16:58:09 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 06619160AE3; Thu, 29 Sep 2016 14:58:09 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 4A27F160AD7
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 29 Sep 2016 16:58:08 +0200 (CEST)
Received: (qmail 34688 invoked by uid 500); 29 Sep 2016 14:58:07 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 34679 invoked by uid 99); 29 Sep 2016 14:58:07 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Sep 2016 14:58:07 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 241A6180BD4
	for <issues@flink.apache.org>; Thu, 29 Sep 2016 14:58:07 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -7.019
X-Spam-Level: 
X-Spam-Status: No, score=-7.019 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-2.999] autolearn=disabled
Received: from mx2-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id ZP8ZzIGJMvWB for <issues@flink.apache.org>;
	Thu, 29 Sep 2016 14:58:06 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 7259D5FB0B
	for <issues@flink.incubator.apache.org>; Thu, 29 Sep 2016 14:58:05 +0000 (UTC)
Received: (qmail 34611 invoked by uid 99); 29 Sep 2016 14:58:04 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Sep 2016 14:58:04 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 3940BE0105; Thu, 29 Sep 2016 14:58:04 +0000 (UTC)
From: greghogan <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2568-flink@git.apache.org>
In-Reply-To: <git-pr-2568-flink@git.apache.org>
Subject: [GitHub] flink pull request #2568: [FLINK-4636] Add boundary check for priorityqueue ...
Content-Type: text/plain
Message-Id: <20160929145804.3940BE0105@git1-us-west.apache.org>
Date: Thu, 29 Sep 2016 14:58:04 +0000 (UTC)
archived-at: Thu, 29 Sep 2016 14:58:09 -0000

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2568#discussion_r81155827
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractCEPPatternOperator.java ---
    @@ -126,11 +126,12 @@ public void restoreState(FSDataInputStream state) throws Exception {
     
     		int numberPriorityQueueEntries = ois.readInt();
     
    -		priorityQueue = new PriorityQueue<StreamRecord<IN>>(numberPriorityQueueEntries, new StreamRecordComparator<IN>());
    -
    -		for (int i = 0; i <numberPriorityQueueEntries; i++) {
    -			StreamElement streamElement = streamRecordSerializer.deserialize(new DataInputViewStreamWrapper(ois));
    -			priorityQueue.offer(streamElement.<IN>asRecord());
    +		if(numberPriorityQueueEntries > 0) {
    +			priorityQueue = new PriorityQueue<StreamRecord<IN>>(numberPriorityQueueEntries, new StreamRecordComparator<IN>());
    --- End diff --
    
    Initialize with size `Math.max(INITIAL_PRIORITY_QUEUE_CAPACITY, numberPriorityQueueEntries)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---