Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5B022200B84 for ; Tue, 20 Sep 2016 09:46:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5989C160AC9; Tue, 20 Sep 2016 07:46:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 93A9F160AA9 for ; Tue, 20 Sep 2016 09:46:03 +0200 (CEST) Received: (qmail 50644 invoked by uid 500); 20 Sep 2016 07:46:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 50635 invoked by uid 99); 20 Sep 2016 07:46:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Sep 2016 07:46:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 65379C0EEE for ; Tue, 20 Sep 2016 07:46:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.946 X-Spam-Level: X-Spam-Status: No, score=-2.946 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LINKBAIT=2.5, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nPiRAIUtee1H for ; Tue, 20 Sep 2016 07:46:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id CCA0A60D24 for ; Tue, 20 Sep 2016 07:46:00 +0000 (UTC) Received: (qmail 50592 invoked by uid 99); 20 Sep 2016 07:46:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Sep 2016 07:46:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D331CE04A2; Tue, 20 Sep 2016 07:45:59 +0000 (UTC) From: twalthr To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ... Content-Type: text/plain Message-Id: <20160920074559.D331CE04A2@git1-us-west.apache.org> Date: Tue, 20 Sep 2016 07:45:59 +0000 (UTC) archived-at: Tue, 20 Sep 2016 07:46:04 -0000 Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2298 I think adding some comments the methods doesn't hurt. I would merge this PR as it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---