Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-2463-flink@git.apache.org>
In-Reply-To: <git-pr-2463-flink@git.apache.org>
Subject: [GitHub] flink pull request #2463: [FLINK-4538][FLINK-4348] ResourceManager slot allo...
Content-Type: text/plain
Message-Id: <20160905134547.029E9E08B8@git1-us-west.apache.org>
Date: Mon,  5 Sep 2016 13:45:47 +0000 (UTC)
archived-at: Mon, 05 Sep 2016 13:45:53 -0000

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77524239
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotStatus.java ---
    @@ -46,13 +47,21 @@
     	/** if the slot is allocated, jobId identify which job this slot is allocated to; else, jobId is null */
     	private final JobID jobID;
     
    -	public SlotStatus(SlotID slotID, ResourceProfile profiler) {
    -		this(slotID, profiler, null, null);
    +	/** Gateway to the TaskManager which reported the SlotStatus */
    +	private final TaskExecutorGateway taskExecutorGateway;
    --- End diff --
    
    The `SlotStatus` is no longer serializable with this field. Where does the `SlotStatus` come from? If it's coming from the `TaskExecutor`, then the `taskExecutorGateway` has to be retrieved on the `ResourceManager` side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---