flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...
Date Mon, 19 Sep 2016 10:31:56 GMT
GitHub user ramkrish86 opened a pull request:


    FLINK-3322 Allow drivers and iterators to reuse the memory segments

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    Updated PR based on @ggevay 's feedback. Now the drivers are all made of type ResettableDrivers
and we use the existing APIs to reuse the driver and the iterators. The JoinTaskITerator has
now a new method called reset() that allows to reset the iterator's state.
    If we go with the approach then it makes sense to remove the ResettableDriver and add
all the API in it to the Driver interface itself. That is for a later PR. 
    @ggevay - Pls review and give your valuable feedback.
    I tried mvn clean verify and got the tests to pass in flink-runtime and flink-gelly-examples.
One failed 'org.apache.flink.runtime.io.disk.ChannelViewsTest.testWriteAndReadLongRecords'
and when I ran locally it passed again. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-4615_new

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2510
commit e17462881cc2f0137cc8412eb578fb4c42baeb15
Author: Ramkrishna <ramkrishna.s.vasudevan@intel.com>
Date:   2016-09-19T10:27:28Z

    FLINK-3322 Allow drivers and iterators to reuse the memory segments


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message