flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Ewen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4675) Remove Parameter from WindowAssigner.getDefaultTrigger()
Date Tue, 27 Sep 2016 19:05:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15527122#comment-15527122
] 

Stephan Ewen commented on FLINK-4675:
-------------------------------------

It would be okay to break it now (from what we defined as stability guarantees) - but tough
call still.

Do we have a hunch how many people write their own window assigners? If only few people write
custom window assigners, it is probably fine.

> Remove Parameter from WindowAssigner.getDefaultTrigger()
> --------------------------------------------------------
>
>                 Key: FLINK-4675
>                 URL: https://issues.apache.org/jira/browse/FLINK-4675
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Windowing Operators
>            Reporter: Aljoscha Krettek
>             Fix For: 2.0.0
>
>
> For legacy reasons the method has {{StreamExecutionEnvironment}} as a parameter. This
is not needed anymore.
> [~StephanEwen] do you think we should break this now? {{WindowAssigner}} is {{PublicEvolving}}
but I wanted to play it conservative for now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message