flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4624) Gelly's summarization algorithm cannot deal with null vertex group values
Date Thu, 22 Sep 2016 18:48:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514143#comment-15514143
] 

ASF GitHub Bot commented on FLINK-4624:
---------------------------------------

Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2527#discussion_r80109825
  
    --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/Summarization.java
---
    @@ -226,11 +247,15 @@ public void setGroupRepresentativeId(K groupRepresentativeId) {
     		}
     
     		public VGV getVertexGroupValue() {
    -			return f2;
    +			return f2.isLeft() ? f2.left() : null;
     		}
     
     		public void setVertexGroupValue(VGV vertexGroupValue) {
    -			f2 = vertexGroupValue;
    +			if (vertexGroupValue == null) {
    +				f2 = new Either.Right<>(NullValue.getInstance());
    --- End diff --
    
    Can these objects be reused?


> Gelly's summarization algorithm cannot deal with null vertex group values
> -------------------------------------------------------------------------
>
>                 Key: FLINK-4624
>                 URL: https://issues.apache.org/jira/browse/FLINK-4624
>             Project: Flink
>          Issue Type: Bug
>          Components: Gelly
>            Reporter: Till Rohrmann
>            Assignee: Martin Junghanns
>             Fix For: 1.2.0
>
>
> Gelly's {{Summarization}} algorithm cannot handle null values in the `VertexGroupItem.f2`.
This behaviour is hidden by using Strings as a vertex value in the {{SummarizationITCase}},
because the {{StringSerializer}} can handle null values. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message