flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils
Date Sat, 10 Sep 2016 21:09:22 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15480465#comment-15480465
] 

ASF GitHub Bot commented on FLINK-4610:
---------------------------------------

Github user apivovarov commented on the issue:

    https://github.com/apache/flink/pull/2491
  
    @twalthr Can you look at this PR?


> Replace keySet/getValue with entrySet in UdfAnalyzerUtils
> ---------------------------------------------------------
>
>                 Key: FLINK-4610
>                 URL: https://issues.apache.org/jira/browse/FLINK-4610
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.1.2
>            Reporter: Alexander Pivovarov
>            Priority: Minor
>
> Map.keySet + getValue combination is not very efficient
> It can be replaced with Map.entrySet to avoid values lookup
> Also MapEntry allows to modify MapEntry value while iterating thought the map using entrySet.iterator



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message