flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4580) Check that the RpcEndpoint supports the specified RpcGateway
Date Wed, 21 Sep 2016 13:27:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509900#comment-15509900
] 

ASF GitHub Bot commented on FLINK-4580:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2526

    [FLINK-4580] [rpc] Report rpc invocation exceptions to the caller

    Reports rpc invocations back to the caller.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink rpcErrorReporting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2526
    
----
commit b52fb356d48850453956d2f6c4e52ba8fe2da8ab
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2016-09-21T13:18:27Z

    [FLINK-4580] [rpc] Report rpc invocation exceptions to the caller

----


> Check that the RpcEndpoint supports the specified RpcGateway
> ------------------------------------------------------------
>
>                 Key: FLINK-4580
>                 URL: https://issues.apache.org/jira/browse/FLINK-4580
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>
> When calling {{RpcService.connect}} the user specifies the type of the {{RpcGateway}}.
At the moment, it is not checked whether the {{RpcEndpoint}} actually supports the specified
{{RpcGateway}}.
> I think it would be good to add a runtime check that the corresponding {{RpcEndpoint}}
supports the specified {{RpcGateway}}. If not, then we can let the connect method fail fast.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message