flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter
Date Mon, 26 Sep 2016 14:06:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523155#comment-15523155
] 

ASF GitHub Bot commented on FLINK-4564:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2517#discussion_r80477622
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTest.java
---
    @@ -280,4 +282,65 @@ public void testConfigurableDelimiter() {
     
     		registry.shutdown();
     	}
    +
    +	@Test
    +	public void testConfigurableDelimiterForReporters() {
    +		Configuration config = new Configuration();
    +		config.setString(ConfigConstants.METRICS_REPORTERS_LIST, "test1,test2,test3");
    +		config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test1." + ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,
"_");
    +		config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test1." + ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX,
TestReporter.class.getName());
    +		config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test2." + ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,
"-");
    +		config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test2." + ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX,
TestReporter.class.getName());
    +		config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test3." + ConfigConstants.METRICS_REPORTER_SCOPE_DELIMITER,
"AA");
    +		config.setString(ConfigConstants.METRICS_REPORTER_PREFIX + "test3." + ConfigConstants.METRICS_REPORTER_CLASS_SUFFIX,
TestReporter.class.getName());
    +
    +		MetricRegistry registry = new MetricRegistry(config);
    +
    +		assertEquals('.', registry.getDelimiter());
    --- End diff --
    
    introducing a static final char field for the global delimiter would improve readability.


> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
>                 Key: FLINK-4564
>                 URL: https://issues.apache.org/jira/browse/FLINK-4564
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Anton Mushin
>
> Currently, the delimiter used or the scope string is based on a configuration setting
shared by all reporters. However, different reporters may have different requirements in regards
to the delimiter, as such we should allow reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no specific setting
was set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message