flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4564) [metrics] Delimiter should be configured per reporter
Date Fri, 23 Sep 2016 13:22:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516422#comment-15516422
] 

ASF GitHub Bot commented on FLINK-4564:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2517#discussion_r80239440
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
    @@ -72,14 +74,12 @@ public MetricRegistry(Configuration config) {
     		}
     		this.scopeFormats = scopeFormats;
     
    -		char delim;
    -		try {
    -			delim = config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER, ".").charAt(0);
    -		} catch (Exception e) {
    -			LOG.warn("Failed to parse delimiter, using default delimiter.", e);
    -			delim = '.';
    +		String defaultDelimiter = config.getString(ConfigConstants.METRICS_SCOPE_DELIMITER,
".");
    +		if(defaultDelimiter.length()!=1){
    --- End diff --
    
    these changes are unnecessary, renaming ```delimiter``` to ```globalDelimiter``` should
be sufficient.


> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
>                 Key: FLINK-4564
>                 URL: https://issues.apache.org/jira/browse/FLINK-4564
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Anton Mushin
>
> Currently, the delimiter used or the scope string is based on a configuration setting
shared by all reporters. However, different reporters may have different requirements in regards
to the delimiter, as such we should allow reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no specific setting
was set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message