flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4547) Return same object when call connect method in AkkaRpcService using same address and same rpc gateway class
Date Wed, 07 Sep 2016 02:53:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469325#comment-15469325
] 

ASF GitHub Bot commented on FLINK-4547:
---------------------------------------

Github user beyond1920 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2455#discussion_r77753174
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
    @@ -189,7 +191,49 @@ public void stop() {
     		rpcEndpoint.tell(Processing.STOP, ActorRef.noSender());
     	}
     
    -	// ------------------------------------------------------------------------
    +	@Override
    +	public boolean equals(Object o) {
    +		if (this == o) {
    +			return true;
    +		}
    +
    +		if (o == null) {
    +			return false;
    +		}
    +
    +		if(Proxy.isProxyClass(o.getClass())) {
    +			return o.equals(this);
    +		}
    --- End diff --
    
    @StephanEwen , as till said, the subject of this pr is misleading. I means When call connect
method in AkkaRpcService using same address and same rpc gateway class, the returned gateways
are equals instead of return same gateway. I changed the subject.


> Return same object when call connect method in AkkaRpcService using same address and
same rpc gateway class
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-4547
>                 URL: https://issues.apache.org/jira/browse/FLINK-4547
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: zhangjing
>            Assignee: zhangjing
>
> Now every time call connect method in AkkaRpcService class using same address and same
rpc gateway class, the return gateway object is totally different with each other which equals
and hashcode are not same. 
> Maybe it’s reasonable to have the same result (equals return true, and hashcode is
same) when using the same address and same Gateway class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message