flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster
Date Mon, 05 Sep 2016 13:49:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465054#comment-15465054
] 

ASF GitHub Bot commented on FLINK-4538:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77524626
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/LeaderIdRegistry.java
---
    @@ -15,11 +15,27 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    +package org.apache.flink.runtime.highavailability;
     
    -package org.apache.flink.runtime.resourcemanager;
    +import java.util.UUID;
     
    -import java.io.Serializable;
    +/**
    + * Registry class to keep track of the current leader ID.
    + */
    +public class LeaderIdRegistry {
    --- End diff --
    
    Why do you create a registry for a single field?


> Implement slot allocation protocol with JobMaster
> -------------------------------------------------
>
>                 Key: FLINK-4538
>                 URL: https://issues.apache.org/jira/browse/FLINK-4538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message