flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4538) Implement slot allocation protocol with JobMaster
Date Mon, 05 Sep 2016 13:31:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465000#comment-15465000
] 

ASF GitHub Bot commented on FLINK-4538:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2463#discussion_r77522339
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
    @@ -52,15 +58,28 @@
      * </ul>
      */
     public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> {
    -	private final Map<JobMasterGateway, InstanceID> jobMasterGateways;
    +
    +	private final Logger LOG = LoggerFactory.getLogger(getClass());
    --- End diff --
    
    Why not making it static?


> Implement slot allocation protocol with JobMaster
> -------------------------------------------------
>
>                 Key: FLINK-4538
>                 URL: https://issues.apache.org/jira/browse/FLINK-4538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message