flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4510) Always create CheckpointCoordinator
Date Thu, 01 Sep 2016 08:22:22 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15454744#comment-15454744
] 

ASF GitHub Bot commented on FLINK-4510:
---------------------------------------

GitHub user wuchong opened a pull request:

    https://github.com/apache/flink/pull/2453

    [FLINK-4510] [checkpoint] Always create CheckpointCoordinator

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This pull request always create checkpoint coordinator even if checkpointing interval
is not configured. 
    
    I use a flag to indicate disabled periodic checkpoint,  Instead of using an interval of
0. Because the interval is checked everywhere, too scared to change it... 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wuchong/flink FLINK-4510-checkpoint

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2453
    
----
commit 7ba16434e3d450e0e1e9a8176a1c575945400bcd
Author: Jark Wu <wuchong.wc@alibaba-inc.com>
Date:   2016-09-01T08:15:33Z

    [FLINK-4510] [checkpoint] Always create CheckpointCoordinator

----


> Always create CheckpointCoordinator
> -----------------------------------
>
>                 Key: FLINK-4510
>                 URL: https://issues.apache.org/jira/browse/FLINK-4510
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Jark Wu
>
> The checkpoint coordinator is only created if a checkpointing interval is configured.
This means that no savepoints can be triggered if there is no checkpointing interval specified.
> Instead we should always create it and allow an interval of 0 for disabled periodic checkpoints.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message