flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4505) Implement TaskManagerFactory to bring up TaskManager for different modes
Date Mon, 05 Sep 2016 06:15:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464203#comment-15464203

ASF GitHub Bot commented on FLINK-4505:

Github user wangzhijiang999 commented on the issue:

    @tillrohrmann , I tried to understand your idea as follows:
    1. Provide specific TaskExecutorFactory class instead of abstract factory for both standalone/yarn
    2. Network selection and RPC service creation methods should be pulled out from factory,
maybe remove to some utility class?(for JM reuse)
    3. The constructor of TaskExecutorFactory supports many different parameters: such as

    TaskExecutorFactory(Configuration, ResourceID)
    TaskExecutorFactory(RpcService, HighAvailabilityServices)
    TaskExecutorFactory(hostname, port)
    TaskExecutorFactory(Configuration, ResourceID, RpcService, HighAvailabilityServices,hostname,
    The above three constructors for partial parameters can be transformed into the fourth
final constructor , all the missing parameters can be generated by internal default value.
    4. The TaskExecutorFactory supports the method "createTaskManger" to bring up TaskManger
for outside  world, and this method will construct the related components(TaskManagerConfiguration,
NetworkManager, IOManager, MemoryManager)
    5. For testing mode, construct the TestingTaskExecutorFactory to pass all the components
explicitly, including (ResourceID,MemoryManager,IOManager,NetworkEnvironment,numberOfSlots,
RpcService,HighAvailabilityServices), the TaskManagerConfiguration should be passed from outside
or generate implicitly?
    6. In addition, the localTaskManagerCommunication parameter is needed before to decide
whether to create NettyConfig for standalone or yarn mode. Now I will remove this parameter
to create ~~NettyConfig~~ always.

> Implement TaskManagerFactory to bring up TaskManager for different modes
> ------------------------------------------------------------------------
>                 Key: FLINK-4505
>                 URL: https://issues.apache.org/jira/browse/FLINK-4505
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>            Priority: Minor
> Implement {{TaskExecutorFactory}} that should be an abstract class with the helper methods
to bring up the {{TaskManager}}. The factory can be implemented by some classes to start a
{{TaskManager}} in different modes (testing, standalone, yarn).

This message was sent by Atlassian JIRA

View raw message