flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4490) Decouple Slot and Instance
Date Fri, 02 Sep 2016 08:18:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457902#comment-15457902

ASF GitHub Bot commented on FLINK-4490:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManager.scala
    @@ -19,20 +19,19 @@
     package org.apache.flink.mesos.runtime.clusterframework
     import org.apache.flink.runtime.clusterframework.types.ResourceID
    -import org.apache.flink.runtime.instance.InstanceConnectionInfo
     import org.apache.flink.runtime.io.disk.iomanager.IOManager
     import org.apache.flink.runtime.io.network.NetworkEnvironment
     import org.apache.flink.runtime.leaderretrieval.LeaderRetrievalService
     import org.apache.flink.runtime.memory.MemoryManager
    -import org.apache.flink.runtime.taskmanager.{TaskManager, TaskManagerConfiguration}
    +import org.apache.flink.runtime.taskmanager.{TaskManager, TaskManagerConfiguration, TaskManagerLocation}
     /** An extension of the TaskManager that listens for additional Mesos-related
       * messages.
     class MesosTaskManager(
         config: TaskManagerConfiguration,
         resourceID: ResourceID,
    -    connectionInfo: InstanceConnectionInfo,
    +    connectionInfo: TaskManagerLocation,
    --- End diff --
    Shall we rename the variable accordingly?

> Decouple Slot and Instance
> --------------------------
>                 Key: FLINK-4490
>                 URL: https://issues.apache.org/jira/browse/FLINK-4490
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Kurt Young
>             Fix For: 1.2.0
> Currently, {{Slot}} and {{Instance}} holds each other. For {{Instance}} holding {{Slot}},
it makes sense because it reflects how many resources it can provide and how many are using.

> But it's not very necessary for {{Slot}} to hold {{Instance}} which it belongs to. It
only needs to hold some connection information and gateway to talk to. Another downside for
{{Slot}} holding {{Instance}} is that {{Instance}} actually contains some allocate/de-allocation
logicals, it will be difficult if we want to do some allocation refactor without letting {{Slot}}
> We should abstract the connection information of {{Instance}} to let {{Slot}} holds.
(Actually we have {{InstanceConnectionInfo}} now, but lacks of instance's akka gateway, maybe
we can just adding the akka gateway to the {{InstanceConnectionInfo}})

This message was sent by Atlassian JIRA

View raw message