flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4455) Replace ActorGateways in NetworkEnvironment by interfaces
Date Thu, 01 Sep 2016 13:34:21 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455399#comment-15455399
] 

ASF GitHub Bot commented on FLINK-4455:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2449#discussion_r77174082
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
---
    @@ -476,6 +252,29 @@ public void unregisterTask(Task task) {
     		}
     	}
     
    +	public void start() throws IOException {
    +		synchronized (lock) {
    +			LOG.info("Starting the network environment and its components.");
    --- End diff --
    
    Check for `isShutdown` here to be safe.


> Replace ActorGateways in NetworkEnvironment by interfaces
> ---------------------------------------------------------
>
>                 Key: FLINK-4455
>                 URL: https://issues.apache.org/jira/browse/FLINK-4455
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network, TaskManager
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{NetworkEnvironment}} communicates with the outside world ({{TaskManager}} and {{JobManager}})
via {{ActorGateways}}. This bakes in the dependency on actors. 
> In terms of modularization and an improved abstraction (especially wrt Flip-6) I propose
to replace the {{ActorGateways}} by interfaces which exposes the required methods. The current
implementation would then simply wrap the method calls in messages and send them via the {{ActorGateway}}
to the recipient.
> In Flip-6 the {{JobMaster}} and the {{TaskExecutor}} could simply implement these interfaces
as part of their RPC contract.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message