flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4389) Expose metrics to Webfrontend
Date Mon, 05 Sep 2016 14:14:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465108#comment-15465108
] 

ASF GitHub Bot commented on FLINK-4389:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2363#discussion_r77527854
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricDump.java
---
    @@ -0,0 +1,119 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.runtime.metrics.dump;
    +
    +/**
    + * A container for a dumped metric that contains the scope, name and value(s) of the
metric.
    + */
    +public abstract class MetricDump {
    +	/** Categories to be returned by {@link MetricDump#getCategory()} to avoid instanceof
checks. */
    +	public static final byte METRIC_CATEGORY_COUNTER = 0;
    +	public static final byte METRIC_CATEGORY_GAUGE = 1;
    +	public static final byte METRIC_CATEGORY_HISTOGRAM = 2;
    +
    +	/** The scope information for the stored metric. */
    +	public final QueryScopeInfo scopeInfo;
    +	/** The name of the stored metric. */
    +	public final String name;
    +
    +	private MetricDump(QueryScopeInfo scopeInfo, String name) {
    +		this.scopeInfo = scopeInfo;
    +		this.name = name;
    --- End diff --
    
    `checkNotNull` missing


> Expose metrics to Webfrontend
> -----------------------------
>
>                 Key: FLINK-4389
>                 URL: https://issues.apache.org/jira/browse/FLINK-4389
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics, Webfrontend
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-7%3A+Expose+metrics+to+WebInterface



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message