flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4248) CsvTableSource does not support reading SqlTimeTypeInfo types
Date Wed, 21 Sep 2016 10:03:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509447#comment-15509447
] 

ASF GitHub Bot commented on FLINK-4248:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2303#discussion_r79798819
  
    --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/FieldParser.java ---
    @@ -174,6 +174,62 @@ protected void setErrorState(ParseErrorState error) {
     	public ParseErrorState getErrorState() {
     		return this.errorState;
     	}
    +
    +	/**
    +	 * Returns the end position of a string with a numeric format (like XXXX-XX-XX). Sets
the error state if the
    +	 * string contains leading/trailing whitespaces or if the column is empty.
    +	 *
    +	 * @return the end position of the string or -1 if an error occurred
    +	 */
    +	public final int formattedStringEndPos(byte[] bytes, int startPos, int limit, byte[]
delimiter) {
    --- End diff --
    
    make `protected`?


> CsvTableSource does not support reading SqlTimeTypeInfo types
> -------------------------------------------------------------
>
>                 Key: FLINK-4248
>                 URL: https://issues.apache.org/jira/browse/FLINK-4248
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Timo Walther
>
> The Table API's {{CsvTableSource}} does not support to read all Table API supported data
types. For example, it is not possible to read {{SqlTimeTypeInfo}} types via the {{CsvTableSource}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message