flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3950) Add Meter Metric Type
Date Wed, 07 Sep 2016 12:58:23 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470554#comment-15470554
] 

ASF GitHub Bot commented on FLINK-3950:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2443#discussion_r77815865
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
---
    @@ -105,7 +106,9 @@ public void setup(StreamTask<?, ?> containingTask, StreamConfig
config, Output<S
     		String operatorName = containingTask.getEnvironment().getTaskInfo().getTaskName().split("->")[config.getChainIndex()].trim();
     		
     		this.metrics = container.getEnvironment().getMetricGroup().addOperator(operatorName);
    -		this.output = new CountingOutput(output, this.metrics.counter("numRecordsOut"));
    +		Counter c = this.metrics.counter("numRecordsOut");
    +		this.output = new CountingOutput(output, c);
    +		this.metrics.meter("numRecordsOutRate", new MeterView(c, 60));
    --- End diff --
    
    I think the metric name should include the unit, in this case perMinute.


> Add Meter Metric Type
> ---------------------
>
>                 Key: FLINK-3950
>                 URL: https://issues.apache.org/jira/browse/FLINK-3950
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Stephan Ewen
>            Assignee: Ivan Mushketyk
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message