flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2055) Implement Streaming HBaseSink
Date Mon, 05 Sep 2016 17:53:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465491#comment-15465491
] 

ASF GitHub Bot commented on FLINK-2055:
---------------------------------------

Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2332#discussion_r77547915
  
    --- Diff: flink-streaming-connectors/flink-connector-hbase/src/main/java/org/apache/flink/streaming/connectors/hbase/HBaseMapper.java
---
    @@ -0,0 +1,46 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.hbase;
    +
    +import org.apache.flink.api.common.functions.Function;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Maps a input value to a row in HBase table.
    + *
    + * @param <IN> input type
    + */
    +public interface HBaseMapper<IN> extends Function, Serializable {
    +
    +	/**
    +	 * Given an input value return the HBase row key. Row key cannot be null.
    +	 *
    +	 * @param value
    +	 * @return row key
    +	 */
    +	byte[] rowKey(IN value);
    --- End diff --
    
    Rest looks good to me. I think naming of functions am not sure if it can be fine tuned.
Am not very good at naming. And also FLINK team may have some naming conventions. I think
having a connect() method and the above comment are the main things from my side. If it is
fine, then it is upto Flink team to review this. Thanks @delding .


> Implement Streaming HBaseSink
> -----------------------------
>
>                 Key: FLINK-2055
>                 URL: https://issues.apache.org/jira/browse/FLINK-2055
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming, Streaming Connectors
>    Affects Versions: 0.9
>            Reporter: Robert Metzger
>            Assignee: Erli Ding
>
> As per : http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Write-Stream-to-HBase-td1300.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message