flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #2435: [FLINK-4478] [flip-6] Add HeartbeatManager
Date Fri, 30 Sep 2016 14:37:27 GMT
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2435
  
    Thanks for the review @mxm. Concerning your questions:
    
    1. Double checking is necessary due to concurrent accesses. Of course one could also use
locks but that way it is less blocking.
    2. I'll add a test for the `unmonitoring`.
    
    After adding the additional test, I'll merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message