flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...
Date Thu, 29 Sep 2016 15:24:49 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2560#discussion_r81163353
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala
---
    @@ -60,6 +60,7 @@ class FlinkPlannerImpl(
       var root: RelRoot = _
     
       private def ready() {
    +    planner.setExecutor(config.getExecutor)
    --- End diff --
    
    I would not set the planner here as this class is only used by the SQL API. `FlinkRelBuilder.create()`
is a better place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message