flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shijinkui <...@git.apache.org>
Subject [GitHub] flink pull request #2541: [FLINK-4669] scala api createLocalEnvironment() fu...
Date Wed, 28 Sep 2016 16:49:15 GMT
Github user shijinkui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2541#discussion_r80963928
  
    --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
---
    @@ -124,7 +125,7 @@ class StreamExecutionEnvironment(javaEnv: JavaEnv) {
        * Gets the checkpoint config, which defines values like checkpoint interval, delay
between
        * checkpoints, etc.
        */
    -  def getCheckpointConfig = javaEnv.getCheckpointConfig()
    --- End diff --
    
    IDEA ful-tip:
    Methods that follow JavaBean naming contract for accessors are expected to have no side
effects. The recommended convention is to use a parameterless method whenever there are no
parameters and the method have no side effect. This convention supports the uniform access
principle, which says that client code should not be affected by a decision to implement an
attribute as a field or method. The problem is that Java does not implement the uniform access
principle. To bridge that gap, Scala allows you to leave off the empty parentheses on an invocation
of function that takes no arguments. * Refer to Programming in Scala, 10.3 Defining parameterless
methods


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message