flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...
Date Wed, 28 Sep 2016 14:19:23 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2560#discussion_r80919671
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/BatchTableEnvironment.scala
---
    @@ -228,19 +229,13 @@ abstract class BatchTableEnvironment(
       }
     
       /**
    -    * Translates a [[Table]] into a [[DataSet]].
    -    *
    -    * The transformation involves optimizing the relational expression tree as defined
by
    +    * Generates the optimized [[RelNode]] tree from the relational expression tree as
defined by
         * Table API calls and / or SQL queries and generating corresponding [[DataSet]] operators.
         *
         * @param table The root node of the relational expression tree.
    -    * @param tpe The [[TypeInformation]] of the resulting [[DataSet]].
    -    * @tparam A The type of the resulting [[DataSet]].
    -    * @return The [[DataSet]] that corresponds to the translated [[Table]].
    +    * @return The optimized [[RelNode]] tree
         */
    -  protected def translate[A](table: Table)(implicit tpe: TypeInformation[A]): DataSet[A]
= {
    -
    -    validateType(tpe)
    +  private[flink] def optimize(table: Table): RelNode = {
    --- End diff --
    
    `optimize` from `Table` to `RelNode` looks strange. I think `optimize(relNode: RelNode):
RelNode` would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message