flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...
Date Wed, 28 Sep 2016 13:06:00 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2546#discussion_r80902027
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncExceptionHandler.java
---
    @@ -18,12 +18,14 @@
     package org.apache.flink.streaming.runtime.tasks;
     
     /**
    - * Interface for reporting exceptions that are thrown in (possibly) a different thread.
    + * An interface marking a task as capable of handling exceptions thrown
    + * by different threads, other than the one executing the task itself.
      */
     public interface AsyncExceptionHandler {
     
     	/**
    -	 * Registers the given exception.
    +	 * Handles an exception thrown by another thread (e.g. a TriggerTask),
    +	 * other than the one executing the main task.
     	 */
    -	void registerAsyncException(AsynchronousException exception);
    +	void handleAsyncException(String message, Throwable exception);
    --- End diff --
    
    This name change is good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message