flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #2559: [FLINK-4702] [kafka connector] Commit offets to Ka...
Date Wed, 28 Sep 2016 12:50:58 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2559#discussion_r80907326
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
    @@ -285,7 +293,14 @@ public void commitSpecificOffsetsToKafka(Map<KafkaTopicPartition,
Long> offsets)
     
     		if (this.consumer != null) {
     			synchronized (consumerLock) {
    -				this.consumer.commitSync(offsetsToCommit);
    +				if (!commitInProgress) {
    +					commitInProgress = true;
    +					this.consumer.commitAsync(offsetsToCommit, offsetCommitCallback);
    +				}
    +				else {
    +					LOG.warn("Committing previous checkpoint's offsets to Kafka not completed. " +
    --- End diff --
    
    If the user sets a relatively short checkpoint interval, will this be flooding log?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message