flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request #2541: [FLINK-4669] scala api createLocalEnvironment() fu...
Date Tue, 27 Sep 2016 16:17:09 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/StreamExecutionEnvironment.scala
    @@ -124,7 +125,7 @@ class StreamExecutionEnvironment(javaEnv: JavaEnv) {
        * Gets the checkpoint config, which defines values like checkpoint interval, delay
        * checkpoints, etc.
    -  def getCheckpointConfig = javaEnv.getCheckpointConfig()
    --- End diff --
    Calling Java methods with parenthesis or without actually somewhat subject to debate.
    For Scala methods, the writer decides whether it is a method with or without parenthesis.
    For Java, the caller can only "guess" what the method does (is returning a mutable field
considered a side effect?), so in most places we call Java methods as Java methods.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message