flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2540: [FLINK-4606] [cluster management] Integrate the ne...
Date Mon, 26 Sep 2016 13:27:55 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2540#discussion_r80473835
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
    @@ -66,15 +67,16 @@
      *     <li>{@link #requestSlot(SlotRequest)} requests a slot from the resource
manager</li>
      * </ul>
      */
    -public class ResourceManager extends RpcEndpoint<ResourceManagerGateway> implements
LeaderContender {
    +public abstract class ResourceManager<ResourceManagerGateway, WorkerType extends TaskExecutorRegistration>
extends RpcEndpoint implements LeaderContender {
    --- End diff --
    
    I believe this should be 
    
    ```java
     ResourceManager<WorkerType extends TaskExecutorRegistration>
    		extends RpcEndpoint<ResourceManagerGateway>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message