flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #2544: [FLINK-4218] [checkpoints] Do not rely on FileSyst...
Date Fri, 23 Sep 2016 20:23:19 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2544#discussion_r80318790
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java
---
    @@ -301,9 +301,16 @@ public StreamStateHandle closeAndGetHandle() throws IOException {
     					}
     					else {
     						flush();
    +
    +						long size = -1;
    --- End diff --
    
    I am not sure if returning -1 as size on exception is ideal. Currently, this value should
one be used in the calculation of meta data, but one might be tempted to use it e.g. to preallocate
a byte[] to read the file into, so this should at least be documented in `StateObject`. Furthermore,
we make the assumption that the stream position is also equal to the final file size. Not
entirely sure if this holds for all streams and file systems, but I guess this is the best
we can do without asking the file system for meta data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message