flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nielsbasjes <...@git.apache.org>
Subject [GitHub] flink pull request #2330: FLINK-4311 Fixed several problems in TableInputFor...
Date Wed, 21 Sep 2016 11:57:42 GMT
Github user nielsbasjes commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2330#discussion_r79816123
  
    --- Diff: flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -67,18 +66,23 @@
     	protected abstract T mapResultToTuple(Result r);
     
     	/**
    -	 * creates a {@link Scan} object and a {@link HTable} connection
    +	 * Creates a {@link Scan} object and opens the {@link HTable} connection.
    +	 * These are opened here because they are needed in the createInputSplits
    +	 * which is called before the openInputFormat method.
    +	 * So the connection is opened in {@link #configure(Configuration)} and closed in {@link
#closeInputFormat()}.
     	 *
    -	 * @param parameters
    +	 * @param parameters The configuration that is to be used
     	 * @see Configuration
     	 */
     	@Override
     	public void configure(Configuration parameters) {
    -		this.table = createTable();
    -		this.scan = getScanner();
    +		table = createTable();
    +		scan = getScanner();
    --- End diff --
    
    Done. Yet because 'configure()' doesn't have a way to fail nicely I added those checks
to the other methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message