flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] flink pull request #2510: FLINK-3322 Allow drivers and iterators to reuse th...
Date Wed, 21 Sep 2016 05:09:34 GMT
Github user ramkrish86 commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java
    @@ -128,17 +130,22 @@ public void prepare() throws Exception{
     		// create and return joining iterator according to provided local strategy.
    -		if (objectReuseEnabled) {
    -			switch (ls) {
    -				case INNER_MERGE:
    -					this.joinIterator = new ReusingMergeInnerJoinIterator<>(in1, in2, 
    +		if (reset) {
    +			resetForIterativeTasks(in1, in2, serializer1, serializer2, comparator1, comparator2,
    +			reset = false;
    +		}
    +		if (joinIterator == null) {
    --- End diff --
    Can you have a look at this?  If we can really see how cases like the PageRank can be
solved then may be we can have the reset() method to do the actual reset. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message