flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #2330: FLINK-4311 Fixed several problems in TableInputFor...
Date Mon, 19 Sep 2016 20:16:39 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2330#discussion_r79469197
  
    --- Diff: flink-batch-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -93,32 +102,45 @@ private HTable createTable() {
     	}
     
     	@Override
    +	public void open(TableInputSplit split) throws IOException {
    +		if (split == null) {
    +			throw new IOException("Input split is null!");
    +		}
    +
    +		logSplitInfo("opening", split);
    +		scan.setStartRow(split.getStartRow());
    +		lastRow = split.getEndRow();
    +		scan.setStopRow(lastRow);
    +
    +		resultScanner = table.getScanner(scan);
    +		endReached = false;
    +		scannedRows = 0;
    +	}
    +
    +	@Override
     	public boolean reachedEnd() throws IOException {
     		return this.endReached;
     	}
     
     	@Override
     	public T nextRecord(T reuse) throws IOException {
    -		if (this.rs == null){
    +		if (this.resultScanner == null){
    --- End diff --
    
    add a space before `{`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message