flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #2490: [FLINK-4609] Remove redundant check for null in CrossOper...
Date Mon, 19 Sep 2016 18:22:37 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2490
  
    Playing Devil's advocate here:
    
    Does this really improve anything meaningful? This is an API-level operator, not anything
runtime related, so the additional null check is not really important. The code is not getting
simpler in my opinion as well. It worked well before, and every change may introduce another
bug.
    
    Why not focus energies on improvements where the system really gains?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message