flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2275: FLINK-3929 Support for Kerberos Authentication wit...
Date Fri, 16 Sep 2016 12:11:39 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2275#discussion_r79153661
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
---
    @@ -266,23 +268,37 @@ public void createTestTopic(String topic, int numberOfPartitions,
int replicatio
     			zkUtils.close();
     		}
     
    +		LOG.info("Topic {} create request is successfully posted", topic);
    +
     		// validate that the topic has been created
    -		final long deadline = System.currentTimeMillis() + 30000;
    +		final long deadline = System.currentTimeMillis() + Integer.parseInt(zkTimeout);
     		do {
     			try {
    -				Thread.sleep(100);
    +				if(secureMode) {
    +					//increase wait time since in Travis ZK timeout occurs frequently
    +					int wait = Integer.parseInt(zkTimeout) / 100;
    +					LOG.info("waiting for {} msecs before the topic {} can be checked", wait, topic);
    +					Thread.sleep(wait);
    +				} else {
    +					Thread.sleep(100);
    --- End diff --
    
    I would rather retry here instead of waiting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message